]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
location: Don't hide location menu
authorZeeshan Ali (Khattak) <zeeshanak@gnome.org>
Mon, 31 Mar 2014 17:26:04 +0000 (18:26 +0100)
committerZeeshan Ali (Khattak) <zeeshanak@gnome.org>
Tue, 8 Apr 2014 13:11:28 +0000 (14:11 +0100)
If geoclue reports that we can't aquire location, we hide the menu. This
will typically happen when user is offline (and doesn't have a 3G
modem). This is likely not what we want since this like a temporary
situation and user would want the ability to toggle geolocation still
even if its currently not possible any applications to query the
location.

https://bugzilla.gnome.org/show_bug.cgi?id=727398

js/ui/status/location.js

index 211137976d4059549973c808a7c8a6ba3828d9cb..8ae76330b019f3b898658ed8e1f30916ffeeabac 100644 (file)
@@ -123,7 +123,7 @@ const Indicator = new Lang.Class({
         this._propertiesChangedId = this._proxy.connect('g-properties-changed',
                                                         Lang.bind(this, this._onGeocluePropsChanged));
 
-        this._updateMenu();
+        this._availableAccuracyLevel = this._proxy.AvailableAccuracyLevel;
         this._syncIndicator();
 
         this._proxy.AddAgentRemote('gnome-shell', Lang.bind(this, this._onAgentRegistered));
@@ -187,17 +187,12 @@ const Indicator = new Lang.Class({
         this._agent.emit_property_changed('MaxAccuracyLevel', variant);
     },
 
-    _updateMenu: function() {
-        this._availableAccuracyLevel = this._proxy.AvailableAccuracyLevel;
-        this.menu.actor.visible = (this._availableAccuracyLevel != 0);
-    },
-
     _onGeocluePropsChanged: function(proxy, properties) {
         let unpacked = properties.deep_unpack();
         if ("InUse" in unpacked)
             this._syncIndicator();
         if ("AvailableAccuracyLevel" in unpacked)
-            this._updateMenu();
+            this._availableAccuracyLevel = this._proxy.AvailableAccuracyLevel;
     }
 });